-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.20 backports #1603
Merged
Merged
0.20 backports #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trait represents a parsed method call with deserialized arguments, to abstract over call parsing. Then add new registration builder helpers to register method calls with a simplified callback which receives parsed arguments, and can optionally return an async result.
sdroege
force-pushed
the
0.20-backports
branch
from
December 16, 2024 18:19
50b261e
to
912f42b
Compare
Only the ones that can be generated now without requiring any manual implementations.
Leave it up to the consumer to determine the specific version.
It was not exported at all before. Fixes gtk-rs#1597
…t_with_closures() Assume that the invocation is passed as `transfer full` into the closure. This workaround is not going to break with future versions of GLib as fixing the bug was considered a breaking API change. See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4427
sdroege
force-pushed
the
0.20-backports
branch
from
December 16, 2024 18:23
912f42b
to
99b1722
Compare
Once this passes, I'll get out a round of bugfix releases for gtk-rs-core later. gtk4-rs tomorrow, gstreamer-rs Wednesday, gst-plugins-rs Thursday. |
Is the part where we ignore the clippy warning still needed with the latest gir changes? |
Yes |
In 0.20 only, in main it should be fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.